RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

[Nir Lisker]

On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - replaced with exact functional equivalent (in the presence of exceptions, for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8289397: review comments
>  - Revert "8289397: functional equivalent"
>    
>    This reverts commit 6ae0ef60b186c75993fe7faa099140b26593d308.

I don't think the warning should be turned off, it's an important one. These specific cases in the PR are just false positives. In any case, extracting a local variable for the assignment seems like a legitimate approach to me.

-------------

PR: https://git.openjdk.org/jfx/pull/851