RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v3]

[Andy Goryachev]

> - replaced with exact functional equivalent (in the presence of exceptions, for example)

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - 8289397: comment
 - Merge remote-tracking branch 'origin/master' into 8289397.assignment
 - 8289397: review comments
 - Revert "8289397: functional equivalent"
   
   This reverts commit 6ae0ef60b186c75993fe7faa099140b26593d308.
 - 8289397: functional equivalent
 - 8289397: fixed possible assignment in place of a comparison warnings

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/851/files
  - new: https://git.openjdk.org/jfx/pull/851/files/0e2dd17d..35cf1bca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=851&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=851&range=01-02

  Stats: 447117 lines in 7355 files changed: 300776 ins; 103525 del; 42816 mod
  Patch: https://git.openjdk.org/jfx/pull/851.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/851/head:pull/851

PR: https://git.openjdk.org/jfx/pull/851