RFR: 8217853: Cleanup in the D3D native pipeline [v2]

Nir Lisker nlisker at openjdk.org
Sat Jul 30 10:20:53 UTC 2022


On Fri, 17 Jun 2022 09:04:41 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.h line 42:
> 
>> 40:     float position[3] = {0};
>> 41:     float color[3] = {0};
>> 42:     float lightOn = 0;
> 
> how would `isOn` sound ?

The name is taken from `LighBase.java`. I can change it here, but we should consider keeping the parallels.

-------------

PR: https://git.openjdk.org/jfx/pull/789


More information about the openjfx-dev mailing list