RFR: 8217853: Cleanup in the D3D native pipeline [v2]

[Nir Lisker]

On Fri, 29 Jul 2022 21:48:00 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DPhongShader.h line 43:
> 
>> 41: #define VSR_LIGHT_POS 10  // 1 position = 5 * 1 = 5: c10-14
>> 42: // Registers 15-19 free
>> 43: #define VSR_LIGHT_DIRS 20    // 1 direction = 5 * 1 = 5: c20-24
> 
> Comments need to be changed as maxLights is now 3.
> I would not recommend to change the macro values or registers in this PR. Instead mention in the comment that 2 are reserved for future if we want to increase the number of lights.

These will also change when we remove the hard limit on 3 lights (we will be limited by these constant registers, but I don't think anyone needs 50 lights on one mesh...).

There is already a comment saying that 3 are in use and 2 are reserved. Do you mean somewhere else?

-------------

PR: https://git.openjdk.org/jfx/pull/789