RFR: 8287604: Update MarlinFX to 0.9.4.5 [v2]
Laurent Bourgès
lbourges at openjdk.java.net
Wed Jun 1 11:27:42 UTC 2022
On Tue, 31 May 2022 22:25:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Hi,
>> Time is going short before openjfx 19...
>>
>> 2 options:
>> - keep dpqs for corner cases and keep my coding life simple
>> - disable or remove dpqs code in marlinFX for openjfx, so my branches will diverge...
>>
>> Any advice, @kevinrushforth ?
>
>> keep dpqs for corner cases and keep my coding life simple
>
> I think this approach is fine. Diverging the code would likely make it less stable, and you answered the question about the provenance of the code, so there's no issue there. We should try to get this in before RDP1 of JavaFX 19 if possible.
>
> One more thing, as I wrote in my above comment:
>
>> We should file a new JBS Enhancement issue -- similar to what was done for Marlin 0.9.2 via [JDK-8204621](https://bugs.openjdk.java.net/browse/JDK-8204621) rather than using a narrow bug, since that bug is only part of what's being done. The current bug can either be added to the PR, or else that JBS bug (JDK-8274066) can be closed as a duplicate of the new Enhancement.
>
> I took the liberty of filing [JDK-8287604](https://bugs.openjdk.java.net/browse/JDK-8287604) for this enhancement. Can you change the title to:
>
> 8287604: Update MarlinFX to 0.9.4.5
Thx @kevinrushforth
I will look at fixing the test with hidpi very soon
-------------
PR: https://git.openjdk.java.net/jfx/pull/674
More information about the openjfx-dev
mailing list