RFR: 8289255: update Eclipse .classpath and other configuration files

Kevin Rushforth kcr at openjdk.org
Wed Jun 29 15:35:23 UTC 2022


On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev <duke at openjdk.org> wrote:

> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
> - fixed gradlew to use UTF-8 encoding

Once the OCA status has been verified, the review can proceed formally.

@nlisker Would you be able to review these changes? I'm not an Eclipse user.

@kleopatra your input would be helpful, too, if you are willing to take a look.

gradlew line 4:

> 2: 
> 3: #
> 4: # Copyright © 2015-2021 the original authors.

The changes in `gradlew` look fine. I'm surprised the file wasn't already UTF-8.

gradlew line 4:

> 2: 
> 3: #
> 4: # Copyright � 2015-2021 the original authors.

`gradlew` still shows up in the patch with changes. You might need to revert it (e.g., using `git checkout master -- gradlew`) from the command line.

-------------

PR: https://git.openjdk.org/jfx/pull/804


More information about the openjfx-dev mailing list