RFR: 8255940: localStorage is null after window.close() [v6]

[Jay Bhaskar]

On Mon, 28 Feb 2022 13:58:03 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add Review Changes
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 851:
> 
>> 849: 
>> 850:     // FIXME: We should consider supporting access/modification to local storage
>> 851:     // after calling window.close(). See <https://bugs.webkit.org/show_bug.cgi?id=135330>.
> 
> The change of moving this block back here looks good. You can delete the obsolete comment now, right?

agree

> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java line 142:
> 
>> 140:         });
>> 141:     }
>> 142: }
> 
> Minor: can you restore the newline at the end of this file?

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/703