RFR: 8280020: Underline and line-through not straight in WebView [v7]

Kevin Rushforth kcr at openjdk.java.net
Fri Mar 4 14:03:14 UTC 2022


On Fri, 4 Mar 2022 03:29:33 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue: The end point of  line in drawLinesForText , add thickness to the endPoint.y(). In this case origin which is start point and the end point would not be same, and line would be drawn not straight.
>> Solution: Do not add thickness to the y position of end point of line.
>> Start Point(x,y) ----------End Point(x + width, 0)
>
> Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - test needs width and height , during creattion of webview
>  - test needs width and height , during creattion of webview

Looks great. I confirm that the updated test fails without the fix and passes with the fix on both macOS and Windows.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/731


More information about the openjfx-dev mailing list