RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling

Robert Lichtenberger rlichten at openjdk.java.net
Thu Mar 24 05:34:07 UTC 2022


On Wed, 23 Mar 2022 08:15:47 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This fix respects a row factory, if present.
>> It will put the cell that is used to measure the column width as child below the row.
>> In that way the row's style will be used.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 667:
> 
>> 665:             if ((cell.getText() != null && !cell.getText().isEmpty()) || cell.getGraphic() != null) {
>> 666:                 tableRow.applyCss();
>> 667:                 cell.applyCss();
> 
> Just wondering: Is `cell.applyCss();` still needed here?

Right, this is no longer needed. I'll remove it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/757


More information about the openjfx-dev mailing list