RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

[Kevin Rushforth]

On Wed, 30 Mar 2022 10:57:38 GMT, Robert Lichtenberger <rlichten at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 715:
>> 
>>> 713:             tableRow = createMeasureRow(tv, tableSkin, null);
>>> 714:         }
>>> 715:         assert tableRow.getSkin() instanceof SkinBase<?>;
>> 
>> Not sure if there is some convention about code asserts, maybe some else can tell. At least I never saw one in a PR here.
>
> I found assertions in various other parts of the code (e.g. `javafx.scene.control.skin.VirtualFlow<T>`) so I assumed this is ok.

Some old code has assertions, but library code should not use them. Please delete them from any new / modified code.

-------------

PR: https://git.openjdk.java.net/jfx/pull/757