RFR: 8217853: Cleanup in the D3D native pipeline [v2]

[Nir Lisker]

On Fri, 6 May 2022 14:21:58 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.h line 61:
> 
>> 59:     bool lightsDirty = TRUE;
>> 60:     int cullMode = D3DCULL_NONE;
>> 61:     bool wireframe = FALSE;
> 
> It seems like you're using `false` and `FALSE` interchangably (see `D3DPhongMaterial.h` L58). I would suggest using the `false` keyword with the builtin type `bool`, and the `FALSE` constant with the Win32 type `BOOL`.

The original code used the Win-only type. I thought it should be changed too. I should probably do that,

-------------

PR: https://git.openjdk.java.net/jfx/pull/789