RFR: 8285534: Update the 3D lighting test sample [v3]

Kevin Rushforth kcr at openjdk.java.net
Fri May 6 23:17:51 UTC 2022


On Thu, 28 Apr 2022 17:28:34 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Update the the test utility. Includes:
>> * Refactoring since there is no more need the split pre- and post-attenuation and light types.
>> * Added customizable material to the `Boxes` to test the interaction between lights and materials..
>> * Light colors can now be changed.
>> * Added ambient lights,
>> 
>> Note that GitHub decided to count the removal of the `AttenLightingSample` and addition of the `Controls` file as renaming. The sample is now run now only through `LightingSample`.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added ambient lights

This looks like a nice improvement to the test app.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/787


More information about the openjfx-dev mailing list