RFR: 8217853: Cleanup in the D3D native pipeline [v2]

[Nir Lisker]

On Fri, 6 May 2022 14:13:55 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 149:
> 
>> 147:     float spotLightsFactors[MAX_NUM_LIGHTS * 4];   // 2 angles + 1 falloff + 1 padding
>> 148:     for (int i = 0, d = 0, p = 0, c = 0, a = 0, r = 0, s = 0; i < MAX_NUM_LIGHTS; i++) {
>> 149:         D3DLight light = lights[i];
> 
> You're invoking the auto-generated copy constructor of `D3DLight` here, where the original code didn't do that. Just making sure that that's what you intended.

I will change to `D3DLight& light = lights[i];`.

-------------

PR: https://git.openjdk.java.net/jfx/pull/789