RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
Ajit Ghaisas
aghaisas at openjdk.java.net
Thu May 12 05:32:07 UTC 2022
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger <rlichten at openjdk.org> wrote:
> Separate test class added for TreeTableView case.
> Fix is analogous to JDK-8251480.
The fix looks good.
The newly introduced test file needs some cosmetic cleanups.
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Replace "2018, 2021" with just "2022" as this is newly introduced test file.
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 33:
> 31: import javafx.event.Event;
> 32: import javafx.scene.Node;
> 33: import javafx.scene.control.*;
Replace generic import statement with specific ones.
modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 51:
> 49: import java.util.List;
> 50:
> 51: import static org.junit.Assert.*;
Replace generic import statement with specific ones.
-------------
Changes requested by aghaisas (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/779
More information about the openjfx-dev
mailing list