RFR: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set [v2]

[Marius Hanl]

On Thu, 12 May 2022 22:13:38 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8286552: Added space and revert typo fix
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TextFormatter.java line 40:
> 
>> 38:  * <ul>
>> 39:  *     <li>A filter ({@link #getFilter()}) that can intercept and modify user input. This helps to keep the text
>> 40:  *     in the desired format. A default text supplier can be used to provide the initial text.</li>
> 
> I know this is a simple typo, but it is unrelated to your bug fix, and is in public API docs, so I'd like to see it go in separately under a "Fix mistakes in docs" bug. I filed [JDK-8286678](https://bugs.openjdk.java.net/browse/JDK-8286678) to track this and any other such issues that arise (as we've done for most recent releases).

Ah okay, alright. I reverted it.

> modules/javafx.controls/src/main/java/javafx/scene/control/TextFormatter.java line 202:
> 
>> 200: 
>> 201:     void updateValue(String text) {
>> 202:         if (valueConverter != null &&!value.isBound()) {
> 
> Minor: please add a space between the `&&` and `!` operators.

done.

-------------

PR: https://git.openjdk.java.net/jfx/pull/794