RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

[Kevin Rushforth]

On Tue, 24 May 2022 15:20:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding JGObject in plave of raw jni object
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/EventListenerLeakTest.java line 765:
> 
>> 763:         assertEquals("Click count", 6, listeners.get(1).get().getClickCount() + listeners.get(0).get().getClickCount());
>> 764: 
>> 765:         // add events listeners again
> 
> that should be "remove"

I think you may have misunderstood my comment. I didn't mean to suggest that you should remove the blocks of code that you removed in the most recent update -- it was performing a quite useful check. Rather I meant that since you were removing the listeners, the comment `add listeners again` was wrong and should say `remove listeners again`.

-------------

PR: https://git.openjdk.java.net/jfx/pull/799