RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

Jay Bhaskar jbhaskar at openjdk.java.net
Thu May 26 06:37:53 UTC 2022


On Wed, 25 May 2022 12:45:59 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments applied
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp line 34:
> 
>> 32: EventListenerManager& EventListenerManager::get_instance()
>> 33: {
>> 34:     static NeverDestroyed<EventListenerManager> sharedManager;
> 
> This does behave well as a singleton class. But I think the instance should be class member variable or a pointer.

Most of the singleton class implementation is as above in Webkit.

-------------

PR: https://git.openjdk.java.net/jfx/pull/799


More information about the openjfx-dev mailing list