RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

Jay Bhaskar jbhaskar at openjdk.java.net
Fri May 27 16:47:07 UTC 2022


On Fri, 27 May 2022 15:42:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change for unregisterDomWindow function and code cleanup
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp line 57:
> 
>> 55:          }
>> 56: 
>> 57:          if (it->second && it->second->use_count() > 1)
> 
> Shouldn't this be `else if`? The previous block calls `erase(it)`, so it isn't valid to dereference `it` after that call.

Applied and  tested

-------------

PR: https://git.openjdk.java.net/jfx/pull/799


More information about the openjfx-dev mailing list