RFR: 8295078: TextField blurry when inside an TitledPane -> AnchorPane [v2]

Ambarish Rapte arapte at openjdk.org
Wed Nov 2 14:11:46 UTC 2022


On Thu, 13 Oct 2022 01:41:11 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their corresponding `snappedXXXInset()` methods.
>> 
>> Note: The reason the `AnchorPane` inside  a `TitledPane` is blurry in the first place is because a `TitledPane` applies padding to its content.
>> Line 2995 in `modena.css`:
>> 
>> .titled-pane > .content > AnchorPane {
>>     -fx-padding: 0.8em;
>> }
>> 
>> which translates to 9.6px.
>> 
>> EDIT: This is btw a good example of the JUnit 5 feature `@ParameterizedTest` with `@ValueSource`
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8295078: Adjusted Copyright year

modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java line 35:

> 33: import javafx.stage.Stage;
> 34: import org.junit.jupiter.params.ParameterizedTest;
> 35: import org.junit.jupiter.params.provider.ValueSource;

In our tests, we don't mix junit4 and junit5 APIs in single test class.
Could you please find an alternate/junit4 way for these two.

-------------

PR: https://git.openjdk.org/jfx/pull/910


More information about the openjfx-dev mailing list