RFR: 8266396: Save VSCMD_DEBUG output in Windows build [v3]

John Neffenger jgneff at openjdk.org
Wed Nov 2 16:20:48 UTC 2022


On Tue, 1 Nov 2022 12:33:13 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> I would like to give this PR a bump. I still think this is a nice and safe improvement.

Thanks, Marius. I appreciate the time you gave for a thorough review. Nonetheless, it may have served its purpose. Searching for WINSDK_DIR on Google gives me the following results:

1. "build on win10 fails · Issue 288 · javafxports/openjdk-jfx"
2. A Visual Studio 2008 problem
3. A Visual Studio 2015 problem
4. "[JDK-8266396] Save VSCMD_DEBUG output in Windows build"

The first result is an issue in the old sandbox repository. It ends with the following comment linking to the bug report associated with this pull request (also the fourth result):

> Since this issue is pretty common and many others could get here in search of a solution, I found it here: [JDK-8266396][1]

Building on Windows is [surprisingly easy][2], but it took me four years to get there. Perhaps it's time for a more fundamental solution: move the build instructions into the repository, just like the [OpenJDK project did][3], so that we all can participate in keeping them up to date. Changes to the instructions would be made in the same pull requests that change the build.

[1]: https://bugs.openjdk.java.net/browse/JDK-8266396?jql=text%20~%20%22WINSDK_DIR%22%20ORDER%20BY%20created%20DESC
[2]: https://github.com/jgneff/jfxbuild/blob/main/win10/bin/jfxbuild.env
[3]: https://github.com/openjdk/jdk/blob/master/doc/building.md

-------------

PR: https://git.openjdk.org/jfx/pull/488


More information about the openjfx-dev mailing list