RFR: 8222210: JFXPanel popups open at wrong coordinates when using multiple hidpi monitors [v2]

[Johan Vos]

On Wed, 2 Nov 2022 18:50:44 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> I think in this case, `Math.floor()` is what you want. I wonder, though, whether it needs to be converted to an `int` at all? It looks like everywhere it is used, it can be kept as a double.
>> 
>> Btw, I almost wrote a comment asking a question as to whether you were using the values of x, y, width, and height correctly, because I got confused that you were using a Dimension to hold an x,y point. If you decide to keep it as a Dimension, I might suggest adding a clarifying comment.
>
> We need the int values, as they are used to invoke `mouseEvent`, `scrollEvent` and `menuEvent` on `com.sun.javafx.embed.EmbeddedSceneInterface` . 
> For some reason, `scrollEvent` takes doubles, but `mouseEvent` and `menuEvent` take ints.
> I'll use `Math.floor()` instead of the `int` cast. The key thing here is that the strategy for the mouse/scroll/menu events should be the same as the strategy for the window location changes.

> And yes, I did not see Dimension2D - we probably should remove confusion and use Point2D (why does it have more overhead?)

Point2D provides much more functionality -- but has 2 fields only. So it should not be an overhead at all, hence I'll switch to Point2D. Thanks for Pointing that out :)

-------------

PR: https://git.openjdk.org/jfx/pull/924