RFR: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting [v5]

Andy Goryachev angorya at openjdk.org
Thu Nov 3 16:11:47 UTC 2022


On Thu, 3 Nov 2022 10:21:57 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
>>  - 8187145: added tests
>>  - 8187145: clear selected tree table row when setting null selection model
>>  - 8187145: clear selection when setting selection model
>>  - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
>>  - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
>>  - 8187145: whitespace
>>  - 8187145: clear focus
>>  - 8187145: tree table view
>>  - 8187145: fall through
>>  - ... and 1 more: https://git.openjdk.org/jfx/compare/7cb8d679...fed5dfdb
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 500:
> 
>> 498:                 return null;
>> 499:             }
>> 500:             // fall through
> 
> There is no "fall through" here as we return from all conditions in previous case.

same response: there is.

-------------

PR: https://git.openjdk.org/jfx/pull/876


More information about the openjfx-dev mailing list