RFR: 8268877: TextInputControlSkin: incorrect inputMethod event handler after switching skin

Andy Goryachev angorya at openjdk.org
Thu Nov 3 16:57:11 UTC 2022


Using new Skin.install() method to properly install and uninstall inputMethodTextChanged and inputMethodRequests properties on TextInputControl.

This avoids memory leaks resulting from skin change, as well as honors user-set properties when installing an uninstalling.

This PR depends on [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) Skin.install().

-------------

Commit messages:
 - Merge remote-tracking branch 'origin/master' into 8268877.input.method
 - Merge branch '8290844.skin.install' into 8268877.input.method
 - 8290844: review comments
 - 8290844: spelling
 - 8290844: review comments
 - 8290844: review comments
 - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
 - 8290844: review comments
 - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
 - 8290844: review comments
 - ... and 31 more: https://git.openjdk.org/jfx/compare/7f17447a...04f4911e

Changes: https://git.openjdk.org/jfx/pull/903/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=903&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8268877
  Stats: 203 lines in 2 files changed: 118 ins; 40 del; 45 mod
  Patch: https://git.openjdk.org/jfx/pull/903.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/903/head:pull/903

PR: https://git.openjdk.org/jfx/pull/903


More information about the openjfx-dev mailing list