RFR: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting [v5]

Ajit Ghaisas aghaisas at openjdk.org
Fri Nov 4 05:09:59 UTC 2022


On Thu, 3 Nov 2022 16:21:20 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> there is a fall through (return is inside an `if` on line 173). 
>> The original code is a bit confusing, it took me a while to see the fall through cases, that's why I added explicit comments.
>
> There is a `return null` on line 176.
> In that case, we will return from either line 173 or line 176. Hence, there is no fall through.

Any comments on this?

-------------

PR: https://git.openjdk.org/jfx/pull/876


More information about the openjfx-dev mailing list