RFR: 8187145: (Tree)TableView with null selectionModel: throws NPE on sorting [v8]

Andy Goryachev angorya at openjdk.org
Fri Nov 4 16:40:30 UTC 2022


> Setting a null selection model in TableView and TreeTableView produce NPE on sorting (and probably in some other situations) because the check for null is missing in several places. 
> 
> Setting a null selection model is a valid way to disable selection in a (tree)table.
> 
> There is also a similar issue with ListView [JDK-8279640](https://bugs.openjdk.org/browse/JDK-8279640).
> 
> changes:
> - added check for null selection model where it was missing
> - clear focused row index on setting null selection model in TreeTableView
> - clear selected cells on setting a new selection model

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:

 - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
 - 8187145: review comments
 - 8187145: github
 - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
 - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
 - 8187145: added tests
 - 8187145: clear selected tree table row when setting null selection model
 - 8187145: clear selection when setting selection model
 - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
 - Merge remote-tracking branch 'origin/master' into 8187145.null.selection.model
 - ... and 5 more: https://git.openjdk.org/jfx/compare/7f17447a...df3aed13

-------------

Changes: https://git.openjdk.org/jfx/pull/876/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=876&range=07
  Stats: 449 lines in 14 files changed: 354 ins; 12 del; 83 mod
  Patch: https://git.openjdk.org/jfx/pull/876.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/876/head:pull/876

PR: https://git.openjdk.org/jfx/pull/876


More information about the openjfx-dev mailing list