RFR: 8221708 Update Eclipse project files
Andy Goryachev
angorya at openjdk.org
Sun Nov 6 00:24:31 UTC 2022
On Wed, 26 Oct 2022 17:00:03 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>>> I've rebased this on master. For some reason I mistakenly based this on some old version of master.
>>
>> As a reminder, please use `git merge master` rather than `git rebase master` (the latter of which requires a force push and makes incremental reviews harder), especially once this goes `rfr`. Since it is still a Draft PR, a rebase is OK, but a merge is usually preferred.
>
> @kevinrushforth Maybe you can shed some light on these points:
>
> * John's comment above:
> > I've added the manual ones. I think not all of the manual code is correct. `DNDWebViewTest` has no `main` for example. The `swt` tests need eclipse SWT libraries that don't seem to be around.
>
> * John and I found out that trying to run the Gradle projects under apps/samples with Gradle (the `run` taks) fails with an error message saying that these projects are not part of the root `settings.gradle` file. This is true, except for the modules, the other listed projects are `apps` and `systemTests`, neither of which are actual Gradle projects. Is this correct behavior? Why are they Gradle projects?
>
> * I find it odd that `systemTests` is a subfolder of `tests`, yet it's defined as a Gradle project while `tests` isn't. What is the reason?
@nlisker :
regarding the project name 'rt' and the directory name 'jfx' created by git clone - there is a historical reason why the directory name should in fact be 'rt' and not 'jfx', @kevinrushforth could you please explain?
I know the likelihood of any changes to the git project configuration is zero, but perhaps we need to have some explanation of the discrepancy in the name.
-------------
PR: https://git.openjdk.org/jfx/pull/930
More information about the openjfx-dev
mailing list