RFR: 8221708 Update Eclipse project files
Nir Lisker
nlisker at openjdk.org
Sun Nov 6 00:24:32 UTC 2022
On Fri, 28 Oct 2022 21:18:54 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>>> but that's another issue for another time.
>>
>> I respectfully disagree - the initial import (with all the documented extra steps) should result in a clean state - as it is currently with the master branch.
>
>> > but that's another issue for another time.
>>
>> I respectfully disagree - the initial import (with all the documented extra steps) should result in a clean state - as it is currently with the master branch.
>
> But this patch just fixes the Eclipse setup. Changing the Gradle root script is something that should be done when considering the whole repository. If you just import as Gradle projects you will not have the non-Gradle projects anyway, so you won't get any errors on them because Eclipse only builds source folders.
>
>> I don't understand why your Properties UI for ystemTests/testscriptapp1 looks different than mine.
>
> Because yours appears to not be a project, hence no "Project build path" window. I can't see your whole tree, but if Eclipse generates errors on them then it is specified as a source folder somewhere.
>
>> could you repeat the documented steps and import John's branch (with zero modifications) as a new gradle project?
>
> After you delete all projects from the workspace (not from the disk), this will be the same as a new user (only a new user will not have the artifacts that Gradle generates on the first time):
>
> 1. Import as Gradle project the root project. The preview should show you that it will import the modules, apps, and systemTests.
>
> 
>
> Everything else will appear as regular folders because Gradle doesn't know about projects not configured in its script.
>
> 2. Revert all changes the Gradle import made to the repository. At this point the module projects, at the very least, should not have any errors on them. If they do, then there's something else that's wrong.
> 3. Import "Existing projects into workspace" and check the "search for nested projects" while specifying the root. Ignore all projects that appear under `bin` directories (the project file is sometimes copied into there for some reason). At this point all the projects should have no errors except for specifically the projects `apps` and `systemTests` that should not be projects at all (this PR should remove their Eclipse files).
> 4. Delete these 2 projects from the workspace **without deleting nested projects**. Effectively, it just removes their .project file. This is what it looks like now:
>
> 
> @nlisker What Eclipse version do you have? I have 4.22 and Andy has 4.25
4.25 with Buildship 3.1.6.
-------------
PR: https://git.openjdk.org/jfx/pull/930
More information about the openjfx-dev
mailing list