RFR: 8221708 Update Eclipse project files
Andy Goryachev
angorya at openjdk.org
Mon Nov 7 17:05:38 UTC 2022
On Mon, 7 Nov 2022 08:26:58 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> The new changes look good. I get a bogus error marker on the apps folder in Project Explorer, but in Package Explorer there is no error. Looks like some Eclipse hiccup.
>>
>> My only comment is about some classpath files that define more dependencies than needed. For example, manualTests-dnd can use this:
>>
>> <?xml version="1.0" encoding="UTF-8"?>
>> <classpath>
>> <classpathentry combineaccessrules="false" kind="src" path="/swing">
>> <attributes>
>> <attribute name="module" value="true"/>
>> </attributes>
>> </classpathentry>
>> <classpathentry combineaccessrules="false" kind="src" path="/base">
>> <attributes>
>> <attribute name="module" value="true"/>
>> </attributes>
>> </classpathentry>
>> <classpathentry combineaccessrules="false" kind="src" path="/graphics">
>> <attributes>
>> <attribute name="module" value="true"/>
>> </attributes>
>> </classpathentry>
>> <classpathentry combineaccessrules="false" kind="src" path="/controls">
>> <attributes>
>> <attribute name="module" value="true"/>
>> </attributes>
>> </classpathentry>
>> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
>> <attributes>
>> <attribute name="module" value="true"/>
>> </attributes>
>> </classpathentry>
>> <classpathentry excluding=".classpath|.project" kind="src" output="bin" path=""/>
>> <classpathentry kind="output" path="bin"/>
>> </classpath>
>>
>>
>> Everything still works with the extra dependencies, but in general it's better to remove them. Do you want to do that? I can find the minimal dependencies.
>
>> The new changes look good. I get a bogus error marker on the apps folder in Project Explorer, but in Package Explorer there is no error. Looks like some Eclipse hiccup.
>
> Yes, this happens sometimes to me as well. The import process of so many projects sometimes seems to cause an error. If after deleting the error from the problem view + rebuilding, the error doesn't return, then it is likely a bug in Eclipse.
>
>> Everything still works with the extra dependencies, but in general it's better to remove them. Do you want to do that? I can find the minimal dependencies.
>
> I've stripped all the unnecessary dependencies. Also added `.settings` to ignore for a few projects that have sources in their root folder to avoid it being copied to `bin`.
Import as existing project + search for nested projects, 0 errors and 0 warnings. Excellent job, @hjohn !
-------------
PR: https://git.openjdk.org/jfx/pull/930
More information about the openjfx-dev
mailing list