RFR: 8296283: JUnit5 tests using Params API fails to compile [v2]
Ambarish Rapte
arapte at openjdk.org
Mon Nov 7 17:13:43 UTC 2022
On Mon, 7 Nov 2022 16:34:54 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> We have other tests which use `@RunWith(Parameterized.class)` just fine (for example, SkinMemoryLeakTest). Is this about mixing junit4 and junit5 classes?
It is not about mixing. The JUnit5 test added in PR https://github.com/openjdk/jfx/pull/910 which uses annotations from `org.junit.jupiter.params` failed to compile on my local machine throwing following errors:
error: package org.junit.jupiter.params does not exist
error: package org.junit.jupiter.params.provider does not exist
error: cannot find symbol @ValueSource
error: cannot find symbol @ParameterizedTest
This PR fixes that compilation error.
I am not sure how it worked on GHA.
> Do we need to make changes in other tests?
It won't need any changes in existing tests.
-------------
PR: https://git.openjdk.org/jfx/pull/939
More information about the openjfx-dev
mailing list