RFR: 8296330: Tests: Add layout container snapping tests [v2]

Andy Goryachev angorya at openjdk.org
Mon Nov 7 19:46:09 UTC 2022


On Mon, 7 Nov 2022 19:42:01 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more layout container which do not snap their children correctly.
>> 
>> The goal of this PR is to add snapping tests for all layout container.
>> After that we can create issues for all broken layout container, fix them and comment in the corresponding line.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8296330: Added javadoc, made delta a constant, reordered working container on top and renamed ContainerInstruction to ContainerCreator

modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java line 137:

> 135: 
> 136:         assertEquals(widthHeight + snappedPaddingX, container.prefWidth(-1), DELTA, className);
> 137:         assertEquals(widthHeight + snappedPaddingY, container.prefHeight(-1), DELTA, className);

sorry, should have specified in my previous comment - this constant is typically called EPSILON (a Greek letter denoting a very small number)

-------------

PR: https://git.openjdk.org/jfx/pull/936


More information about the openjfx-dev mailing list