RFR: 8296283: JUnit5 tests using Params API fails to compile [v3]
Ambarish Rapte
arapte at openjdk.org
Mon Nov 7 20:32:53 UTC 2022
> This issue was uncovered when running the test added in PR: https://github.com/openjdk/jfx/pull/910
> The JUnit5 tests using Params API fails to compile.
>
> Fix:
> Change dependency of `junit-jupiter-params` from runtime to compile time.
> From: https://junit.org/junit5/docs/current/user-guide/#overview-what-is-junit-5: it can be understood that packages of JUnit Jupiter other than `TestEngine` are required for test compilation and
> JUnit Platform serves as a foundation for [launching testing frameworks](https://junit.org/junit5/docs/current/user-guide/#launcher-api)
>
> It seems that changing dependency of this one package is sufficient for this fix.
Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
address review comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/939/files
- new: https://git.openjdk.org/jfx/pull/939/files/64ba3a96..ff684bec
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=939&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=939&range=01-02
Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/939.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/939/head:pull/939
PR: https://git.openjdk.org/jfx/pull/939
More information about the openjfx-dev
mailing list