RFR: 8296589: PixelBufferDrawTest fails on some systems

Lukasz Kostyra duke at openjdk.org
Thu Nov 10 12:49:39 UTC 2022


On Wed, 9 Nov 2022 19:14:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/scene/PixelBufferDrawTest.java line 189:
>> 
>>> 187: 
>>> 188:     private void compareColor(Color exp, Color act) {
>>> 189:         Assert.assertEquals(exp.getRed(), act.getRed(), 0.01);
>> 
>> Since the tolerance value is used 4 times, maybe consider using a variable? Since this is preexisting, I'll approve it anyway and leave it up to you as to whether to change it.
>
> Since someone initially chose a value w/o justification, perhaps we should create a constant and describe it (using Kevin's comment as a starting point).

I will update it.

-------------

PR: https://git.openjdk.org/jfx/pull/944


More information about the openjfx-dev mailing list