RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

Andy Goryachev angorya at openjdk.org
Thu Nov 10 16:18:02 UTC 2022


On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra <duke at openjdk.org> wrote:

>> Issue happening on some hardware due to slightly different pixel values being returned.
>> 
>> Increased tolerance of asserts in compareColor function to allow these tests to pass (0.01 delta is still tighter than other similar tests which use 0.07).
>
> Lukasz Kostyra has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8296589: PixelBufferDrawTest fails on some systems
>   
>   Issue happening on some hardware due to slightly different pixel values being returned.
>   
>   Increased tolerance of asserts in compareColor function to allow these tests to pass
>   (0.01 delta is tighter than other tests which use 0.07).

I would have made it a static field, but this is also acceptable.

-------------

Marked as reviewed by angorya (Author).

PR: https://git.openjdk.org/jfx/pull/944


More information about the openjfx-dev mailing list