RFR: 8221708 Update Eclipse project files [v3]

Nir Lisker nlisker at openjdk.org
Sun Nov 13 01:47:44 UTC 2022


On Sat, 12 Nov 2022 20:38:49 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary add-exports attribute from Eclipse files

tests/manual/controls/.classpath line 10:

> 8: 	<classpathentry combineaccessrules="false" kind="src" path="/graphics">
> 9: 		<attributes>
> 10: 			<attribute name="add-exports" value="javafx.graphics/com.sun.glass.ui=ALL-UNNAMED:javafx.graphics/com.sun.glass.ui.monocle=ALL-UNNAMED:javafx.graphics/com.sun.javafx.sg.prism=ALL-UNNAMED:javafx.graphics/com.sun.prism.impl=ALL-UNNAMED:javafx.graphics/com.sun.javafx.image.impl=ALL-UNNAMED:javafx.graphics/com.sun.glass.events=ALL-UNNAMED:javafx.graphics/com.sun.javafx.application=ALL-UNNAMED:javafx.graphics/com.sun.javafx.css=ALL-UNNAMED:javafx.graphics/com.sun.javafx.geom=ALL-UNNAMED:javafx.graphics/com.sun.javafx.tk=ALL-UNNAMED:javafx.graphics/com.sun.glass.ui.mac=ALL-UNNAMED"/>

The wrong attribute was removed. The module one should stay, the exports one should be removed.

tests/manual/desktop/.classpath line 23:

> 21: 		</attributes>
> 22: 	</classpathentry>
> 23: 	<classpathentry kind="src" output="bin" path="HostServices"/>

Missing the `excluding=".classpath|.project|.settings"` entry?

-------------

PR: https://git.openjdk.org/jfx/pull/930


More information about the openjfx-dev mailing list