RFR: 8260528: Clean glass-gtk sizing and positioning code [v27]
Johan Vos
jvos at openjdk.org
Thu Nov 17 14:26:29 UTC 2022
On Wed, 16 Nov 2022 23:09:47 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java line 191:
>>
>>> 189: setBoundsImpl(ptr, x, y, xSet, ySet, w, h, cw, ch);
>>> 190:
>>> 191: if ((w <= 0) && (cw > 0) || (h <= 0) && (ch > 0)) {
>>
>> Why is this block removed?
>
> Size adjusting accounting frame extents is done in `WindowContextTop::update_frame_extents()`
I mainly wanted to make sure we were not missing a `notifyResize` event (which was executed in the removed block), but I see this is now done via `WindowContextTop::set_bounds` which is fine.
-------------
PR: https://git.openjdk.org/jfx/pull/915
More information about the openjfx-dev
mailing list