RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v5]

Michael Strauß mstrauss at openjdk.org
Fri Nov 18 03:23:30 UTC 2022


On Thu, 14 Jul 2022 08:05:25 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests "*MultipleSelectionModelImplTest*"`
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK_8256397
>   Fixed more issues with the multiple selection model change events, and verified them with more unit-tests.

Looks good to me.

modules/javafx.controls/src/test/java/test/javafx/scene/control/MultipleSelectionModelImplTest.java line 1470:

> 1468:     }
> 1469: 
> 1470:     public ListView creatListViewWithMultipleSelection() {

There's a typo in "creatList..."

-------------

PR: https://git.openjdk.org/jfx/pull/353


More information about the openjfx-dev mailing list