RFR: JDK-8297332: Remove easy warnings in base

Kevin Rushforth kcr at openjdk.org
Mon Nov 21 15:21:35 UTC 2022


On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations

Per our offline discussion, we don't need as careful of a review of these "remove warnings" changes. Since this is the first one, I'd like a second reviewer, mainly to validate the pattern you are using. It should still be a quick review if nothing odd is spotted.

The main thing to be careful of is that we don't touch any public API signatures, since some of these sort of automated changes can have impact that we would need to consider.

-------------

PR: https://git.openjdk.org/jfx/pull/957


More information about the openjfx-dev mailing list