RFR: JDK-8297332: Remove easy warnings in base

John Hendrikx jhendrikx at openjdk.org
Mon Nov 21 19:56:24 UTC 2022


On Mon, 21 Nov 2022 17:20:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> modules/javafx.base/src/main/java/javafx/beans/property/IntegerPropertyBase.java line 56:
> 
>> 54: 
>> 55:     private int value;
>> 56:     private ObservableIntegerValue observable = null;;
> 
> is there an Eclipse warning for extra semicolon?

Yes, `potential programming problems / empty statement`. It can sometimes point to a mistake where a semi colon is used just before a block.

-------------

PR: https://git.openjdk.org/jfx/pull/957


More information about the openjfx-dev mailing list