RFR: JDK-8297332: Remove easy warnings in base

[John Hendrikx]

On Mon, 21 Nov 2022 17:29:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> modules/javafx.base/src/main/java/javafx/util/converter/DateStringConverter.java line 130:
> 
>> 128: 
>> 129:     /** {@inheritDoc} */
>> 130:     @SuppressWarnings("removal")
> 
> puzzling - why was it marked with @SuppressWarnings("removal") ?

Probably the deprecation for removal warning was first blocked, then later fixed without removing the suppress warnings. There are currently no calls in that code that call anything deprecated, so I remove the suppress warnings.

-------------

PR: https://git.openjdk.org/jfx/pull/957