RFR: JDK-8297332: Remove easy warnings in base
Andy Goryachev
angorya at openjdk.org
Mon Nov 21 20:52:21 UTC 2022
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations
I am not disputing the benefits of generics, but it does have its limits (see many typecasts in TableView and that CssParser example I provided above). Especially CssParser, because it produces errors in one case, but not in the other.
And I agree - perhaps unused imports and missing overrides should be checked by the tool chain - since it already bothers with trailing whitespace.
-------------
PR: https://git.openjdk.org/jfx/pull/957
More information about the openjfx-dev
mailing list