RFR: JDK-8297332: Remove easy warnings in javafx.base

Kevin Rushforth kcr at openjdk.org
Tue Nov 22 13:25:35 UTC 2022


On Mon, 21 Nov 2022 23:59:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> > Just making sure, I can integrate this now?
> 
> format requirements have been fulfilled (1 reviewer, 1 author). go!

Yes, this one was ready to go, thanks for checking.

As a general comment, and not specific to this review, I want to remind folks that meeting the jcheck requirements on the minimum number of approving reviews is necessary, but not sufficient in all cases, since there is no way for Skara to "know" whether a PR is really ready to integrate. It's the responsibility of PR authors, Committers, and Reviewers to ensure that folks have had enough time to comment and that all feedback has been addressed.

-------------

PR: https://git.openjdk.org/jfx/pull/957


More information about the openjfx-dev mailing list