RFR: JDK-8297412: Remove easy warnings in javafx.media, javafx.swing, javafx.swt and javafx.web
Kevin Rushforth
kcr at openjdk.org
Tue Nov 22 15:13:26 UTC 2022
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations
I just noticed that this touches files under `javafx.web/src/main/native`. This will cause extra work for us, since we keep all of the files under `javafx.web/src/main/native` in sync across release families (and we will definitely not backport this entire fix). I need some time to think about this, but it might be better to do these Java files in a separate PR.
-------------
PR: https://git.openjdk.org/jfx/pull/958
More information about the openjfx-dev
mailing list