RFR: JDK-8297414: Remove easy warnings in javafx.controls [v3]

John Hendrikx jhendrikx at openjdk.org
Tue Nov 22 18:45:23 UTC 2022


On Tue, 22 Nov 2022 18:08:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Fix warnings in fxml"
>>   
>>   This reverts commit b148aa3cc8a4676167a9eb8a023cddce3de116e7.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/AccordionTest.java line 57:
> 
>> 55: 
>> 56:     @Before public void setup() {
>> 57:         tk = Toolkit.getToolkit();//This step is not needed (Just to make sure StubToolkit is loaded into VM)
> 
> not equivalent.
> I wonder if we need an assertTrue here

Not needed in the setup, if it is `null` later or throws an exception the test failure is clear enough.

Also a bit out of scope of this PR.

-------------

PR: https://git.openjdk.org/jfx/pull/959


More information about the openjfx-dev mailing list