RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v3]
Nir Lisker
nlisker at openjdk.org
Tue Nov 22 18:49:23 UTC 2022
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert changes to javafx.web src/main/native
modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 769:
> 767: @SuppressWarnings("unchecked")
> 768: public void processEndElement() throws IOException {
> 769: super.processEndElement();
Same question as in line 1446.
modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
> 1444: @Override
> 1445: public void processEndElement() throws IOException {
> 1446: super.processEndElement();
I don't see a warning for it, What setting warns about calling an empty method?
-------------
PR: https://git.openjdk.org/jfx/pull/958
More information about the openjfx-dev
mailing list