RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v3]

[Andy Goryachev]

On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert changes to javafx.web src/main/native

Changes requested by angorya (Author).

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 156:

> 154: 
> 155:         @SuppressWarnings("unchecked")
> 156:         public void add(Object element) {

by removing a checked exception we are changing public API.  do we really want to do that?

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:

> 1444:         @Override
> 1445:         public void processEndElement() throws IOException {
> 1446:             super.processEndElement();

this suggests a specific pattern, even though there is probably no development expected in this class.
i'd keep it as is, and revert making the method abstract in the base class.

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1494:

> 1492:         }
> 1493: 
> 1494:         @Override

why removing it from the base class, just to add it back in multiple places?  is this really necessary?

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1699:

> 1697:         public void processEndElement() {
> 1698:             // No-op
> 1699:         }

and here.

modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/NativeAudioSpectrum.java line 85:

> 83:             magnitudes = new float[bands];
> 84:             for (int i = 0; i < magnitudes.length; i++) {
> 85:                 magnitudes[i] = DEFAULT_THRESHOLD;//Float.NEGATIVE_INFINITY;

might as well remove the comment

modules/javafx.swing/src/main/java/com/sun/javafx/embed/swing/newimpl/SwingNodeInteropN.java line 242:

> 240:          }
> 241:          @Override
> 242:         public void dispose() {

in guthub ui these two lines appear misaligned.  are they really?

-------------

PR: https://git.openjdk.org/jfx/pull/958