RFR: JDK-8297413: Remove easy warnings in javafx.graphics

[Andy Goryachev]

On Tue, 22 Nov 2022 22:30:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I agree.  The problem is that we will not be able to enable the warning in IDE, or it has to be @suppressed.
>> 
>> So the choice is either fix the code and enable warning, or keep the code as is and disable the warning.
>
> I don't see it as a useful warning. The code isn't necessarily better without, and can be less clear. I think this might argue for asking Eclipse users to disable this warning in the IDE.

I do agree with @kevinrushforth here.

It might be borderline useful to enable the warning once just to see if there are any bugs or perhaps to clean up the most obvious cases, but it probably makes little sense to enable the said warning for large and long lived code bases like this one.

-------------

PR: https://git.openjdk.org/jfx/pull/960