RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]
Nir Lisker
nlisker at openjdk.org
Wed Nov 23 21:45:41 UTC 2022
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: @Override
>>> 1445: public void processEndElement() throws IOException {
>>> 1446: super.processEndElement();
>>
>> I don't see a warning for it, What setting warns about calling an empty method?
>
> The `processEndElement` in the base class was an empty method that throws `IOException`. By making it `abstract` the warning is avoided, but this means the call to `super` here is no longer relevant (it wasn't relevant anyway as the base method was empty).
I think that we should refrain from making "structural" changes in this pass. Let's keep the warning on and deal with these later.
-------------
PR: https://git.openjdk.org/jfx/pull/958
More information about the openjfx-dev
mailing list