RFR: JDK-8297414: Remove easy warnings in javafx.controls [v3]
Nir Lisker
nlisker at openjdk.org
Wed Nov 23 22:02:38 UTC 2022
On Tue, 22 Nov 2022 18:48:41 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/FXVKSkin.java line 858:
>>
>>> 856: protected void sendKeyEvents() {
>>> 857: Node target = fxvk.getAttachedNode();
>>> 858:
>>
>> same comment - check for null?
>
> Yes, good catch, fixed.
Eclipse's quick fix is to replace the `instanceof` check with a `null` check, did it not suggest the same for you?
-------------
PR: https://git.openjdk.org/jfx/pull/959
More information about the openjfx-dev
mailing list