RFR: JDK-8297414: Remove easy warnings in javafx.controls [v4]

[John Hendrikx]

On Wed, 23 Nov 2022 22:36:36 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert instanceof changes and replace with null checks
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactory.java line 287:
> 
>> 285:                 .map(d -> new Object[] {d, })
>> 286:                 .collect(toList());
>> 287:         return result;
> 
> According to the javadoc on this method, it's a hack for old Junit versions. Maybe it isn't needed anymore even. Leave as is for this PR anyway.

Sorry, that's not clear, remove the cast or revert this?  Whatever that comment says, I seriously doubt this cast would have any effect on how old JUnit's would behave unless someone is mocking things they shouldn't be (ie. someone mocked the `data` parameter).

-------------

PR: https://git.openjdk.org/jfx/pull/959