RFR: JDK-8297414: Remove easy warnings in javafx.controls [v3]

Wed Nov 23 23:12:36 UTC 2022

On Wed, 23 Nov 2022 22:57:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> This looks like bad test design. If the toolkit needs to be of a specific type when running tests, then check that this is the case once before running all the tests. As for this PR, I don't mind leaving it as is or reverting these changes. I don't think that a CCE is realistic here.
>
>> As for this PR, I don't mind leaving it as is or reverting these changes. I don't think that a CCE is realistic here.
> 
> I agree that this isn't a good test design. I was just pointing out why it isn't (in theory) a completely compatible change. I don't really mind one way or the other here.

I can replace these with an assert:

    assertTrue(Toolkit.getToolkit() instanceof StubToolkit);

-------------

PR: https://git.openjdk.org/jfx/pull/959